Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use executable location as base for various file operations (#180) #185

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Donaldduck8
Copy link

Currently, the FakeNet executable attempts to locate its files in the session's current working directory. However, this is not ideal as configuration files, for example, are actually located relative to the executable's location, not the location from which the user launched the executable. This issue was described in #180.

When inside a PyInstaller bundle, the parent directory of the executable can be retrieved using os.path.dirname(sys.executable).

I have applied this to various file operations throughout FakeNet. If I missed any, please let me know!

Copy link

google-cla bot commented Apr 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant